Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added esc button and x button to exit #183

Merged
merged 4 commits into from
Oct 27, 2024
Merged

added esc button and x button to exit #183

merged 4 commits into from
Oct 27, 2024

Conversation

kellyxzhou
Copy link
Contributor

Description

Added functionality for esc key and a x button to exit

Fixes #163

Type of Change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Is this a breaking change?

  • Yes
  • [ x] No

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jury ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 8:33am

client/src/components/Popup.tsx Outdated Show resolved Hide resolved
client/src/components/Popup.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelZhao21 MichaelZhao21 merged commit 895d9a4 into master Oct 27, 2024
2 checks passed
@MichaelZhao21 MichaelZhao21 deleted the feat/ExitPopup branch October 27, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add other options to exit Popup
2 participants