hacsjson failing unexpectedly

[tykeal]

Describe the issue

The recent change to do more stringent checking of the hacs.json file is all well and good, but my PR tykeal/homeassistant-rental-control#100 to fix the errors on my own repository are still failing in the exact same way as what caused me to look into the failing test stating that extra keys data["domains"] The thing is my change is removing the domains key along with the iot_class key so it should be passing and not failing this check!

Link to action run

https://github.com/tykeal/homeassistant-rental-control/runs/6758204993?check_suite_focus=true

Link to action configuration

https://github.com/tykeal/homeassistant-rental-control/blob/main/.github/workflows/hacs.yaml

Checklist

• I have filled out the issue template to the best of my ability.
• I have read https://hacs.xyz/docs/issues
• This issue is related to the HACS action.
• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).

[hacs-bot]

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍

[ludeeus]

https://github.com/tykeal/homeassistant-rental-control/runs/6748166202?check_suite_focus=true it runs fine for the pull_request trigger on your PR.
Its the push event that fails (its designed to run against the default branch if not in a PR)

[tykeal]

Ahh... thanks, I missed that it was passing on the PR but failing the push validation. I'm fixing my workflow to not do push validation. I always raise PRs back to myself so it's not going to be an issue for me. Thanks for pointing it out to me! I was obviously being blind!

[ludeeus]

It should take the pushed branch so this is still an issue.