Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify naming in clustrmsd and clustfcc #739

Closed
mgiulini opened this issue Oct 30, 2023 · 1 comment · Fixed by #769
Closed

clarify naming in clustrmsd and clustfcc #739

mgiulini opened this issue Oct 30, 2023 · 1 comment · Fixed by #769
Assignees
@mgiulini
Labels
enhancement Enhancing an existing feature of adding a new one m|clustfcc clustfcc module m|clustrmsd

Comments

@mgiulini
Copy link
Contributor

naming in clustering modules should follow #685, namely

tolerance -> clust_cutoff (if numerical value)
tolerance -> n_clusters (if we want a certain number of clusters)
threshold -> min_population
@mgiulini mgiulini self-assigned this Oct 30, 2023
@mgiulini mgiulini added m|clustfcc clustfcc module m|clustrmsd labels Oct 30, 2023
@mgiulini
Copy link
Contributor Author

mgiulini commented Nov 3, 2023

@sverhoeven check this out

@sverhoeven sverhoeven mentioned this issue Nov 15, 2023
Merged
@rvhonorato rvhonorato added the enhancement Enhancing an existing feature of adding a new one label Dec 13, 2023
@mgiulini mgiulini mentioned this issue Jan 3, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiulini mgiulini

Labels
enhancement Enhancing an existing feature of adding a new one m|clustfcc clustfcc module m|clustrmsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Interactive rescoring and reclustering haddocking/haddock3
2 participants
@rvhonorato @mgiulini