-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to check for incompatible parameters #935
Conversation
Manually edited catalog to test incompatible keyword Refs haddocking/haddock3#935 TODO - [ ] generate JSON schema - [ ] handle incompatible fields being in a group - [ ] handle multiple incompatible fields in same object, note allOf did not work
In clustrmsd module the value of criterion parameter determines which other module parameters are ignored see
|
I don't know, because they have default values, and only in some case (based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to remember to edit the default.yaml files when needed to define incompatible parameters, but now at least the machinery to check those is in place - nice!
cannot add code and review at the same time
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
This PR adds a logic to check for parameter incompatibilities.
For example; with #918 I added a new parameter called
less_io
however you cannot use this parameter together withmode=batch
.So now you can define a new
incompatible
property of a given parameter in thehaddock.modules.defaults.yaml
;Which will then be validated when the run is being setup.