-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added integration tests for scoring modules #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep it separated like this into two distinct files?
Or do we want to have an integration test devoted to CNS scoring modules?
Because basically the two scripts are the same, with the only difference from the imports
.
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
i see the point, but would keep the two tests separate for the moment, to follow the current one module-one test pattern |
Exact coordinates might be a hard test as it might depend on the hardware where it is run…
Or you have to perform a RMSD assessment and accept it should be within 0.? A
|
this is a very good idea Alex! |
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
Closes #967 by adding two simple integration tests for the CNS scoring modules. Simple checks on the output are performed. Due to the chaotic nature of the score calculation, the score attribute cannot be checked precisely.