Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the sort from the update override #23

Open
MoistCarrot opened this issue Jul 22, 2021 · 0 comments
Open

Please remove the sort from the update override #23

MoistCarrot opened this issue Jul 22, 2021 · 0 comments

Comments

@MoistCarrot
Copy link

The GaugeController is currently sorting the dataset that is passed into it via this line of code:

dataset.data.sort((a, b) => a - b);

This should be removed, or made configurable. I need my data to be displayed in the order that I pass it in as; not a sorted version of it.

ChartJS doughnuts display data in datasets in sequential order. There isn't really a reason for the gauge chart to sort those values by default. If the user wants their data to be sorted, they can sort the dataset themselves, and pass in that sorted dataset into the update() function.

Please let me know your thoughts on this; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant