Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem markup search result on surfaces with border only, no fill #1127

Closed
mdellming opened this issue Jun 23, 2022 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@mdellming
Copy link

mdellming commented Jun 23, 2022

If we choose to display search results with only border and without fill, we get a problem with some parts of the selection being obscured by other search hit markings when using star marking or clicking on a hit and expanding info (for example, for real estate polygons).
Sometimes only 1 or 2 borders of a polygon appear in the map, and the others seem to fall below nearby items that are in the search hits list but not selected, as if the borders overlap.
When creating selections from the search hits list, for example with star marking, or when marking a post in the list and expanding info for it, we want the selection/expanded object to always end up as the top marking of the map image, both the border and any surface fill, and be displayed as whole polygons /objects in the map.

Requests prio for search result markings:

  • general search result - Secondary (shown below, if any of the other options mentioned below are used)
  • star selection - Primary (always show selection on top of general search results as whole objects)
  • click on search result and expanding info – Primary (always show selection on top of general search results as whole object)

github_sökträff

@Hallbergs Hallbergs self-assigned this Jun 27, 2022
@Hallbergs Hallbergs added the bug label Jun 27, 2022
@Hallbergs Hallbergs added this to the 3.10 milestone Jun 27, 2022
@Hallbergs
Copy link
Member

I think i've sorted this bug. Fix coming up.

I understood the issue, and found a logic-error in the code, but i could not reproduce the error for some reason... If the fix doesn't work, we'll just re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants