Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue: used color is not "perfect" in layer compare function (and other Dialog windows based plugins) #1179

Closed
JakubPelka opened this issue Sep 19, 2022 · 1 comment
Closed

Accessibility issue: used color is not "perfect" in layer compare function (and other Dialog windows based plugins) #1179

JakubPelka opened this issue Sep 19, 2022 · 1 comment
Assignees
@jacobwod
Labels
bug module:client/core Core functionality (not a plugin)
Milestone
3.11

Comments

@JakubPelka
Copy link

Describe the bug
While running in darkmode it is not easy to see text describing "reset and close" in layer comparer window.

To Reproduce
image
Expected behavior
White color instead of blue
@jacobwod jacobwod self-assigned this Sep 19, 2022
@jacobwod jacobwod added bug module:client/core Core functionality (not a plugin) labels Sep 19, 2022
@jacobwod jacobwod added this to the 3.11 milestone Sep 19, 2022
@jacobwod
Copy link
Member

I'll fix the secondary action button to have better contrast, depending on the background color. Something like this in dark mode:

Skärmavbild 2022-09-19 kl 09 42 38

@jacobwod jacobwod changed the title Accessibility issue - used color is not "perfect" in layer compare function Accessibility issue: used color is not "perfect" in layer compare function (and other Dialog windows based plugins) Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
bug module:client/core Core functionality (not a plugin)
Projects
None yet
Milestone
3.11
Development

No branches or pull requests
2 participants
@jacobwod @JakubPelka