Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers configured with < a /> tags without proper url-values in infoBox causes errors. #901

Closed
Hallbergs opened this issue Nov 11, 2021 · 0 comments
Assignees
Labels
bug difficulty:easy Functionality is considered easy to port module:client/core Core functionality (not a plugin)
Milestone

Comments

@Hallbergs
Copy link
Member

If the admin has set up a layer in the following manner (as an example)...
image

... and the url-parameter is nullish, we will get an error in the client when we info-click. See image below:

image

We are error:ing since we are creating a element and passing nullish children to it.

Proposed fix:
Conditional rendering of the link component, see below:

From this:
image

To this:
image

Thoughts?

@Hallbergs Hallbergs added bug difficulty:easy Functionality is considered easy to port module:client/core Core functionality (not a plugin) labels Nov 11, 2021
@Hallbergs Hallbergs added this to the 3.8 milestone Nov 11, 2021
@Hallbergs Hallbergs self-assigned this Nov 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug difficulty:easy Functionality is considered easy to port module:client/core Core functionality (not a plugin)
Projects
None yet
Development

No branches or pull requests

1 participant