Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes timer doesn't work when using RevealNotes.open() #2157

Closed
denehyg opened this issue May 5, 2018 · 1 comment
Closed

Notes timer doesn't work when using RevealNotes.open() #2157

denehyg opened this issue May 5, 2018 · 1 comment

Comments

@denehyg
Copy link
Contributor

denehyg commented May 5, 2018

Programatically opening the notes window using RevealNotes.open() fails to reference the Reveal object as this is scoped to RevealNotes rather than the global scope. As a result the timer function is unable to work.

notesPopup.Reveal = this.Reveal;

This does not occur when opening the notes window from the keyboard as this is scoped to the global object.

I believe this should be notesPopup.Reveal = window.Reveal instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants