Wrap paths to resolve with double quote #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjorgensen
requested changes
Aug 11, 2023
chrjorgensen
added
the
bug
6 tasks
Co-authored-by: Christian Jorgensen <chr.jorgensen1@gmail.com>
|
New test is passing - thank you @chrjorgensen! |
chrjorgensen
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
@worksofliam All tests pass now - will approve and merge! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will fix a bug that will allow the vscode-rpgle extension to resolve streamfiles with spaces in them (though... what crazy person would do that?!)
Tests are continuing to pass.
Checklist
console.logs I added