-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move elm-scripts
into a separate package (like create-react-app)
#183
Comments
Alternatively, c-e-a should add itself as a dependency of the new project and then this works as designed but is less effort. See how I've done it here: https://github.com/jackfranklin/do-you-even-elm/blob/master/package.json |
@jackfranklin this is a good idea! We are trying to avoid introducing a local I don't know if that's a reasonable ambition, personally, I prefer to use a single global version of Create Elm App and introduce local npm dependencies in Elm Apps if it's totally necessary. I have started splitting up the project already, but I there's no consensus on local npm dependencies yet. Let's get some more feedback and try to figure out the best way of pulling this off. My original motivation for splitting the project is to simplify the development process on the utilities and see what kind of opportunities we will get in the context of extensibility. I would like to enable users to fork |
I think in any realistic project it's pretty likely that you will end up needing a |
Isn’t it possible to just |
Let's say as as user I have created my app with c-e-a and now I want to setup
npm run deploy
which runselm-app build
and then some custom deploy script.This will work if I have
elm-app
installed globally but it means that all my colleagues also have to ensure they are running the same version.What create-react-app does is install
react-scripts
locally into the new project it creates.react-scripts
contains thebuild
,start
,test
andeject
commands. It then creates apackage.json
with this in:This also means if they update react-scripts with a bug fix, any user can get that fix by installing the latest react-scripts.
I think we should consider replicating this for create-elm-app as I think it adds a few benefits. What do you think @halfzebra ? :)
The text was updated successfully, but these errors were encountered: