Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plugin extension tab cannot be displayed when only having plugin view permissions #4746

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: plugin extension tab cannot be displayed when only having plugin view permissions #4746

merged 1 commit into from
Oct 19, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Oct 18, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind bug
/area console

What this PR does / why we need it:

修复用户仅拥有插件查看权限时，有setting的插件会导致无法加载插件扩展tab的问题

Which issue(s) this PR fixes:

Fixes #4732

Special notes for your reviewer:

  1. 使用如下测试版 s3 插件
    plugin-s3-1.5.0-SNAPSHOT.jar.zip
    https://github.com/longjuan/halo-plugin-s3os/tree/aaa
  2. 创建一个用户，仅赋予 S3 Link 权限（依赖于插件查看和附件管理权限）
  3. 登录这个新用户，打开 s3 插件详情
  4. 观察 关联S3文件 功能是否正常出现

Does this PR introduce a user-facing change?

修复部分场景下插件详情的扩展 tab 不能正常显示的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 18, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove October 18, 2023 04:56
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #4746 (5a98c3c) into main (9e33a81) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4746   +/-   ##
=========================================
  Coverage     61.58%   61.58%           
  Complexity     2797     2797           
=========================================
  Files           403      403           
  Lines         14725    14725           
  Branches       1023     1023           
=========================================
  Hits           9068     9068           
  Misses         5165     5165           
  Partials        492      492

ruibaby
ruibaby reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
JohnNiang
JohnNiang approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit ff7af9f into halo-dev:main Oct 19, 2023
2 checks passed
@JohnNiang JohnNiang added this to the 2.11.x milestone Oct 19, 2023
@JohnNiang
Copy link
Member

/cherrypick release-2.10

@halo-dev-bot halo-dev-bot mentioned this pull request Oct 19, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #4749

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Oct 19, 2023
@halo-dev-bot
[release-2.10] fix: plugin extension tab cannot be displayed when onl…
26bcf43 
…y having plugin view permissions (#4749)

This is an automated cherry-pick of #4746

/assign JohnNiang

```release-note
修复部分场景下插件详情的扩展 tab 不能正常显示的问题
```
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

用户仅拥有插件查看权限时，对于有setting的插件会导致无法加载插件扩展tab
4 participants
@longjuan @JohnNiang @halo-dev-bot @ruibaby