Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verified badge for email field in profile detail page #5783

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 23, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.15.x

What this PR does / why we need it:

在个人中心的个人资料页面添加邮箱已验证的标识,方便用户知晓。

image

Does this PR introduce a user-facing change?

在个人中心的个人资料页面添加邮箱已验证的标识。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang April 23, 2024 10:29
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (87c260e).
Report is 140 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5783      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.37%     
- Complexity     3319     3373      +54     
============================================
  Files           587      605      +18     
  Lines         18968    19879     +911     
  Branches       1401     1371      -30     
============================================
+ Hits          10795    11240     +445     
- Misses         7594     8067     +473     
+ Partials        579      572       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

amazing looks🤠

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@wan92hen
Copy link
Collaborator

/approve

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@LIlGG
Copy link
Member

LIlGG commented Apr 25, 2024

能否在 Console 中的用户详情上也显示是否已经认证的图标?

目前无法在 Console 端明确感知目标用户是否已经认证邮箱。

image

@ruibaby
Copy link
Member Author

ruibaby commented Apr 25, 2024

能否在 Console 中的用户详情上也显示是否已经认证的图标?

目前无法在 Console 端明确感知目标用户是否已经认证邮箱。

image

Good!但是在 Console 里可能也需要显示未验证的状态。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby requested a review from LIlGG April 26, 2024 03:31
@ruibaby
Copy link
Member Author

ruibaby commented Apr 26, 2024

能否在 Console 中的用户详情上也显示是否已经认证的图标?
目前无法在 Console 端明确感知目标用户是否已经认证邮箱。
image

Good!但是在 Console 里可能也需要显示未验证的状态。

已添加。

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link

f2c-ci-robot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, wan92hen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f2b883f into halo-dev:main Apr 26, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants