fix(timestamps): only create timestamp triggers when necessary

haltcase · Jun 24, 2019 · 35dbab6 · 35dbab6
1 parent c901d98
commit 35dbab6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -5,7 +5,7 @@ import * as knex from 'knex'
 
 import Model from './model'
 import { runQuery } from './helpers'
-import { toKnexSchema, createTimestampTrigger } from './schema-helpers'
+import { toKnexSchema } from './schema-helpers'
 import { pureConnect } from './sqljs-handler'
 import { defaultTo, invariant, makeDirPath } from './util'
 
@@ -147,8 +147,6 @@ export class Trilogy {
       }
     }
 
-    // tslint:disable-next-line:no-floating-promises
-    createTimestampTrigger(model)
     return model
   }
 

diff --git a/src/schema-helpers.ts b/src/schema-helpers.ts
@@ -54,6 +54,9 @@ export function toKnexSchema <D extends types.ReturnDict> (
       const value = (options as any)[key]
       if (key === 'timestamps' && options.timestamps) {
         table.timestamps(false, true)
+
+        // tslint:disable-next-line:no-floating-promises
+        createTimestampTrigger(model)
       } else if (key === 'index') {
         createIndices(table, value)
       } else {