Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /consider_distance_to_river.html #5

Open
louiseschreyers opened this issue Apr 21, 2023 · 1 comment
Open

Issue on page /consider_distance_to_river.html #5

louiseschreyers opened this issue Apr 21, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@louiseschreyers
Copy link
Collaborator

I have one question on this. For the distance to river intersection, in the cases where you have more than one intersection point per area considered (such as the one on the figure): do you sum up all values or do you take the mean? Just to know, I did not see the mention of river discharge data except in the title, so maybe remove it? I see this analysis as an exploration of different variables in relation to rivers. It might be good in the correlation table to indicate the categories labels instead of the categories code, for easier readability :)

@hammerdirt-analyst hammerdirt-analyst self-assigned this May 9, 2023
@hammerdirt-analyst hammerdirt-analyst added documentation Improvements or additions to documentation question Further information is requested labels May 9, 2023
@hammerdirt-analyst
Copy link
Owner

hammerdirt-analyst commented May 9, 2023

The chapter on river intersections was updated:

For the distance to river intersection, in the cases where you have more than one intersection point per area considered (such as the one on the figure): do you sum up all values or do you take the mean?

  1. Yes
  2. The analysis was run using aggregated and non aggregated. Also using river and lake survey locations and just lake survey locations. There is example dataframe output for all conditions.

sample output aggregated

Other notes: The definition of the code labels has been added. The distance and length calculations were reviewed and revised. Adding the the length of the river survey locations required this. However, the these calculations are now much more accesible and can be added to the survey data by using an outer merge on the location column of both sets of data (survey data and river length and distance data)

Update The chapter title was changed and octopus pots ? were changed to other borken glass. There are no octopuss farms on lac léman

Thank you for your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants