fix: 修改导入三方件路径为/开头转换时找不到文件错误 #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qican77
reviewed
Sep 4, 2023
| const vpath = path.resolve(rootPath, oriPath.substr(1)) | ||
| if (!fs.existsSync(vpath)) { | ||
| return '' | ||
| const wpath = path.resolve(sourceFilePath,'..' + oriPath + '.js') |
qican77
reviewed
Sep 4, 2023
| if (!fs.existsSync(vpath)) { | ||
| return '' | ||
| const wpath = path.resolve(sourceFilePath,'..' + oriPath + '.js') | ||
| const vpath = path.resolve(rootPath,oriPath.substr(1)) |
There was a problem hiding this comment.
逗号后空格，提交前运行npm run lint 和 npm run format
| return '' | ||
| const wpath = path.resolve(sourceFilePath,'..' + oriPath + '.js') | ||
| const vpath = path.resolve(rootPath,oriPath.substr(1)) | ||
| if(!fs.existsSync(vpath)){ |
There was a problem hiding this comment.
写成if(!fs.existsSync(vpath) && !fs.existsSync(wpath))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/<
/!--
请务必阅读贡献者指南:
https://github.com/NervJS/taro/blob/master/CONTRIBUTING.md
-->
这个 PR 做了什么? (简要描述所做更改)
fix: 修改导入三方件路径为/开头转换时找不到文件错误
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: