Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency bitflags to v2? #210

Closed
LeoniePhiline opened this issue Nov 21, 2023 · 3 comments
Closed

Update dependency bitflags to v2? #210

LeoniePhiline opened this issue Nov 21, 2023 · 3 comments
Labels
good first issue help wanted

Comments

@LeoniePhiline
Copy link
Contributor

bitflags v2 became available in March 2023: https://crates.io/crates/bitflags/versions

Major changes: https://github.com/bitflags/bitflags/releases/tag/2.0.0

Maybe it is feasible to upgrade from v1 to v2?
@hannobraun
Copy link
Owner

Hey @LeoniePhiline, thank you for opening this issue!

That upgrade does indeed look feasible. I'd be happy to accept a pull request!

@LeoniePhiline LeoniePhiline mentioned this issue Nov 22, 2023
Merged
@hannobraun
Copy link
Owner

I can't think of a reason to remove any of those implementations. I think it's probably best to keep all of them around. (I see that's what you've already done in your pull request 👍)

@hannobraun
Copy link
Owner

Addressed in #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannobraun @LeoniePhiline