Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get rename to work #13

Open
michaelkonecny opened this issue May 14, 2019 · 2 comments
Open

Can't get rename to work #13

michaelkonecny opened this issue May 14, 2019 · 2 comments

Comments

@michaelkonecny
Copy link

Hi,

sorry to bother you. I noticed you added symbol renaming.

I just can't get it to work.

I've tried right clicking on the variable and selecting rename

image

as well as Ctrl+Shift+P -> Nuclide Refactorizer: Rename, but neither seem to work.

Can you please just tell me how you invoke the command so I can debug further?

@hansec
Copy link
Owner

hansec commented May 14, 2019

Oops, actually I don't think "rename" is supported yet by the Atom LS interface. I have only used this feature in VSCode. It was included on the README for this package by accident. The rename menu option doesn't work on Atom for me either and it doesn't look like Atom is sending a rename request to the server so it might be Nuclide specific.

@michaelkonecny
Copy link
Author

Yeah, it seems as though this was WIP in atom-ide-ui before Facebook dropped the project, so hopefully someone will take it up in the community project...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants