Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Security Audit #4

Closed
c-thiel opened this issue May 14, 2024 · 2 comments · Fixed by #64
Closed

Fix Security Audit #4

c-thiel opened this issue May 14, 2024 · 2 comments · Fixed by #64
Assignees
Labels
security Security Relevant issues
Milestone

Comments

@c-thiel
Copy link
Contributor

c-thiel commented May 14, 2024

Currently the security Audit is failing:
https://github.com/hansetag/iceberg-rest-server/actions/runs/9081717741

@c-thiel c-thiel added the security Security Relevant issues label May 14, 2024
@c-thiel c-thiel added this to the Release 0.1.0 milestone May 14, 2024
@twuebi
Copy link
Contributor

twuebi commented Jun 5, 2024

I looked a bit into this, it appears there's an issue with the rsa implementation used as transitive dependencies of some of our dependencies, from the looks it seems to be rather long-standing, there's work happening to resolve it but not much movement since April.

The other one is yaml-serde which has recently been marked as unmaintained, some background can be found here.

Both don't seem to have any quick fixes, we may want to consider to ignore these advisories via a audit.toml (https://github.com/rustsec/rustsec/blob/main/cargo-audit/audit.toml.example) and monitor their status.

@c-thiel
Copy link
Contributor Author

c-thiel commented Jun 6, 2024

To get rid of the issue caused by config, we could also think about moving to clap instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security Relevant issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants