Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add isMissing to boom on types #294

Merged
merged 1 commit into from
May 1, 2022
Merged

Conversation

damusix
Copy link
Contributor

@damusix damusix commented Mar 31, 2022

No description provided.

@damusix damusix changed the title docs: add isMissing to boom on types fix: add isMissing to boom on types Mar 31, 2022
@devinivy devinivy added the types TypeScript type definitions label May 1, 2022
@devinivy devinivy added this to the 9.1.5 milestone May 1, 2022
@devinivy devinivy merged commit c35a140 into hapijs:master May 1, 2022
devinivy added a commit that referenced this pull request May 1, 2022
@devinivy
Copy link
Member

devinivy commented May 1, 2022

I merged this, but ended-up reverting, as the isMissing is already handled in the types (

boom/lib/index.d.ts

Lines 198 to 204 in c2293a2

interface MissingAuth {
/**
* Indicate whether the 401 unauthorized error is due to missing credentials (vs. invalid)
*/
isMissing: boolean;
}
), and this change actually made boom's type tests fail. If we want to make a change like this I think it requires a closer look.

@devinivy devinivy removed this from the 9.1.5 milestone May 1, 2022
@damusix
Copy link
Contributor Author

damusix commented May 2, 2022

@devinivy I do apologize. Will definitely be more careful next time!

@devinivy
Copy link
Member

devinivy commented May 2, 2022

No worries! I missed it too. I am not sure why CI didn't run properly for this PR, but I think that would have cleared it up pretty quickly for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants