Support node v18 and drop node v12, make exports ESM-friendly #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
added
breaking changes
kanongil
approved these changes
May 9, 2022
There was a problem hiding this comment.
I'm very much in favour of moving it to a standardized Engine() export. Though I would probably revise catbox to validate passed objects a bit more, so it throws on the base exported object. Otherwise you will have weird runtime errors if people just upgrade the module without changes to the code.
|
Good call @kanongil, I've captured that here: hapijs/catbox#240 |
Co-authored-by: Gil Pedersen <github@gpost.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports.Enginerather thanmodule.exportsfor more standard ESM usage. If that seems fine, I'll apply the same convention to catbox-redis, etc.If this looks good, this will go out as catbox-memory v6.