Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans to support Hapi v21? #179

Open
rossanthony opened this issue Feb 21, 2023 · 2 comments
Open

Are there plans to support Hapi v21? #179

rossanthony opened this issue Feb 21, 2023 · 2 comments

Comments

@rossanthony
Copy link
Contributor

As well as updating the dev dependency to hapi v21 here it seems like the types dependency of "@types/hapi__hapi": "^20.0.10" should be removed, since the types are now included with the core library of Hapi since v21: https://github.com/hapijs/hapi/tree/master/lib/types

Would I be able to help by opening a PR to take care of this? Looks like there's a need to cut a new major version of hapi-pino (v12) which will work with Hapi v21 typescript projects.

@mcollina
Copy link
Collaborator

Sure thing, send a PR over!

@rossanthony
Copy link
Contributor Author

thanks @mcollina here's the PR: #180. The tests for the types had to be tweaked a bit, following the changes in Hapi v21 related to the Server type and the new server function that starts and returns a server.

Also thought it might be helpful to include a table of the hapi and pino versions supported by each version of this library, since we had some confusion around this earlier today when updating one of our projects to Hapi v21. We saw there was a v11 of hapi-pino but the readme only mentions as far as v9 in terms of support for hapi v20. So we tried it out hoping that maybe the latest hapi-pino would work with hapi v21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants