Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why log a 'warn' when a handler throws an exception? #74

Closed
ryanhallcs opened this issue Apr 18, 2019 · 2 comments
Closed

Why log a 'warn' when a handler throws an exception? #74

ryanhallcs opened this issue Apr 18, 2019 · 2 comments

Comments

@ryanhallcs
Copy link
Contributor

The readme correctly asserts the logger issues a log of a thrown error with the level warn (also see: https://github.com/pinojs/hapi-pino/blob/master/index.js#L81-L87)

I'm wondering the reason behind this, because I need to discern which logs to transport for proper error processing (i.e. needing to send to a system like Sentry or Raygun, or even simple log filtering for errors by level) - and lowering that threshold to warn doesn't sound correct to me. Curious if I'm misunderstanding something

@mcollina
Copy link
Collaborator

I don’t remember. There might be a rationale, but it has been lost in the years.
Would you like to send a PR?

@ryanhallcs
Copy link
Contributor Author

@mcollina - I know how that goes :) pr submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants