Question | Hapi Pino Decorates Server Object with Logger as a Function

[GoPro16]

Had a quick question as to the reason the logger is decorated onto the server as a function returning the logger vs. just decorating the server object with the logger instance itself. However, the logger object on the request is not a function.

Example (feature request):

server.decorate(server,'logger',logger)

https://github.com/pinojs/hapi-pino/blob/2d57bb6f0b186fa8212f84dc42e91ab2b8f95d8a/index.js#L83

In our microservices we heavily use the decorate method on the server object for a few different things but haven't had a case where we needed to use it as a method returning what we want.

We may be missing something here so if it was intended I would love to know the explanation so we can potentially refactor some of our plugins to do so in this way. Otherwise it would be nice to not have to return the logger as a function

[mcollina]

I don't think any good reason for this, and git blame points to the initial commit.

I think it's because the docs states the signature is

server.decorate(type, property, method, [options])

Note that it is method.

Does it work with objects too? In case, would you like to send a PR?

[GoPro16]

Sure! Sadly it will be breaking change but I think it will help clear up some confusion when people have to mix and match the server logged and request logged destructures