Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply array.single() regardless of options.convert #1836

Closed
hueniverse opened this issue Jun 1, 2019 · 2 comments
Closed

Apply array.single() regardless of options.convert #1836

hueniverse opened this issue Jun 1, 2019 · 2 comments
Assignees
Labels
breaking changes Change that can breaking existing code
Milestone

Comments

@hueniverse
Copy link
Contributor

No description provided.

@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Jun 1, 2019
@hueniverse hueniverse added this to the 16.0.0 milestone Jun 1, 2019
@hueniverse hueniverse self-assigned this Jun 1, 2019
@AdriVanHoudt
Copy link
Contributor

This feels counterintuitive, is there a specific reason for this?

@hueniverse hueniverse changed the title Apply array.single() regardless of options.covert Apply array.single() regardless of options.convert Jun 3, 2019
@hueniverse
Copy link
Contributor Author

Because it is not data conversion or dual purpose rule. Same way object.rename() doesn't obey options.convert. Basically, we have three types of rules: data modifiers (rename()), data validators (min()), and combination of both (uppercase()).

single() is a modifier, not a validator. It has no purpose without convert.

@hueniverse hueniverse added the v16 label Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code
Projects
None yet
Development

No branches or pull requests

2 participants