Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values prevent AKS from upgrading Kubernetes version and node image #69

Closed
jesuslpm opened this issue Jun 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@jesuslpm
Copy link

jesuslpm commented Jun 3, 2023

PodDisruptionBudget prevents cluster from upgrading when controller.replicaCount = 1. I would like to suggest you to change controller.replicaCount default value to 2.

@jesuslpm jesuslpm changed the title Default values prevent AKS from upgrading version and node image Default values prevents AKS from upgrading version and node image Jun 3, 2023
@jesuslpm jesuslpm changed the title Default values prevents AKS from upgrading version and node image Default values prevent AKS from upgrading version and node image Jun 3, 2023
@jesuslpm jesuslpm changed the title Default values prevent AKS from upgrading version and node image Default values prevent AKS from upgrading Kubernetes version and node image Jun 3, 2023
@jcmoraisjr
Copy link
Member

Makes sense, thanks for sharing. I'd however add a PodDisruptionBudget only if minAvailable is between 1 and replicas-1, what do you think? #73 implements that approach.

@jcmoraisjr jcmoraisjr added the enhancement New feature or request label Jul 2, 2023
@jcmoraisjr
Copy link
Member

Should be solved in the next controller releases. Closing.

@jesuslpm
Copy link
Author

jesuslpm commented Jul 6, 2023

Thank you. I think adding a PodDisruptionBudget only if minAvailable is between 1 and replicas-1 is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants