Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound needs to use a sane default for config.me in the HELO/EHLO #2757

Closed
baudehlo opened this issue Feb 6, 2020 · 2 comments · Fixed by #2813
Closed

Outbound needs to use a sane default for config.me in the HELO/EHLO #2757

baudehlo opened this issue Feb 6, 2020 · 2 comments · Fixed by #2813

Comments

@baudehlo
Copy link
Collaborator

baudehlo commented Feb 6, 2020

No more description required. Connection.js uses: config.get('me') || os.hostname().

@msimerson
Copy link
Member

I can't immediately think of any reason why outbound can't use the same.

@msimerson
Copy link
Member

I just peeked inside haraka-net-utils and see that it exports get_primary_host_name.

exports.get_primary_host_name = function () {
  return exports.config.get('me') || os.hostname();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants