chore: update rusty_v8 to 0.84.0 (denoland#587)

V8 is now at version 12.3.

Cargo.toml

@@ -22,7 +22,7 @@ deno_core = { version = "0.263.0", path = "./core" }
 deno_ops = { version = "0.139.0", path = "./ops" }
 serde_v8 = { version = "0.172.0", path = "./serde_v8" }
 
-v8 = { version = "0.83.2", default-features = false }
+v8 = { version = "0.84.0", default-features = false }
 deno_ast = { version = "=0.32.0", features = ["transpiling"] }
 deno_unsync = "0.3.2"
 deno_core_icudata = "0.0.73"

core/modules/map.rs

@@ -544,7 +544,7 @@ impl ModuleMap {
         .get_specifier()
         .to_rust_string_lossy(tc_scope);
 
-      let import_attributes = module_request.get_import_assertions();
+      let import_attributes = module_request.get_import_attributes();
 
       let attributes = parse_import_attributes(
         tc_scope,

testing/unit/tc39_test.ts

@@ -1,5 +1,5 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-import { fail, test } from "checkin:testing";
+import { assert, assertEquals, fail, test } from "checkin:testing";
 
 // Verify that "array by copy" proposal is enabled (https://github.com/tc39/proposal-change-array-by-copy)
 test(function testArrayByCopy() {
@@ -38,3 +38,27 @@ test(function testIteratorHelpers() {
     fail("failed");
   }
 });
+
+// Verify that "Set Methods" proposal is enabled (https://github.com/tc39/proposal-set-methods)
+test(function testSetMethods() {
+  {
+    const odds = new Set([1, 3, 5, 7, 9]);
+    const squares = new Set([1, 4, 9]);
+    const intersection = odds.intersection(squares);
+    assertEquals(intersection.size, 2);
+    assert(intersection.has(1));
+    assert(intersection.has(9));
+  }
+  {
+    const evens = new Set([2, 4, 6, 8]);
+    const squares = new Set([1, 4, 9]);
+    const union = evens.union(squares);
+    assertEquals(union.size, 6);
+    assert(union.has(2));
+    assert(union.has(4));
+    assert(union.has(6));
+    assert(union.has(8));
+    assert(union.has(1));
+    assert(union.has(9));
+  }
+});