-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Success Pull Request Comment is not send, while errors are working fine #637
Comments
@0ptaq0 that might be a bug :) |
There are many sfdx-hardis features embedded within hardis:project:deploy:sources:dx, including JIRA ones. hardis:source:deploy currently only embeds the errors comment. The corresponding call of your use case would be the following:
you would also need to define the following variables in your gitlab-ci.yml variables:
SFDX_DEPLOY_WAIT_MINUTES=300
PACKAGE_XML_TO_DELETE=dx-delta/destructiveChanges/destructiveChanges.xml Please can you try to check if it works on your project ? :) |
Additional note: after merge, if you use the following script, you will benefit of QuickDeploy :)
|
Thank you Nicolas, JIRA integration now works like a charm :) Regarding I have only one issue with destructive changes, the env var
My flow looks like this:
SFDX Git Delta creates a diff package and package.xml + destructiveChanges.xml which I then archive and pass to sfdx-hardis. Also as mentioned above I am using custom CICD and embedded sfdx-hardis so I do not have any As a workaround, I can also check if destructive Changes are not empty and then call yet another sfdx deployment command, but the best would be to fit everything in one shot ;) |
@0ptaq0 do you know that sfdx-git-delta is also embedded within sfdx-hardis and project:source:deploy:dx ? :) https://sfdx-hardis.cloudity.com/salesforce-ci-cd-config-delta-deployment/ I'm wondering if you are not trying to reproduce the standard sfdx-hardis pipeline :) https://github.com/hardisgroupcom/sfdx-hardis/blob/main/defaults/ci/.gitlab-ci.yml https://github.com/hardisgroupcom/sfdx-hardis/blob/main/defaults/ci/.gitlab-ci-config.yml Can you compare with your pipeline ? I feel the only difference is that
If you want, please share your gitlab-ci.yml and i'll tell you :) |
I am using sfdx hardis in my custom Gitlab pipeline.
Pipelines are running bounded to Merge Requests, 'Enable merged results pipelines' option is enabled >>
"This pipeline ran on the contents of the merge request combined with the contents of the target branch"
I have added following env variables:
My validation/deployment command looks almost the same, only difference is
--checkonly
flag:During deployment I would expect some success message posted to Merge Request comment and optionally to related JIRA in MR's description, but I am getting below:
However, posting error comments works just fine:
And then I can see a comment with great tips on how to solve errors ;)
Also, nothing is posted to JIRA but that's a minor item, I would just need a success comment to Merge Request at this moment.
What am I missing?
The text was updated successfully, but these errors were encountered: