fix: remove links preload script at init mode when using Nuxt SSG #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am using this awesome library with Nuxt in SSG mode. It works very well when using the 'mount' mode, but I noticed that it doesn't delay all scripts from loading when using the 'init' mode. When I dug deeper into the source code, I discovered that in 'init' mode, the library removes script tags from the body. However, when I use Nuxt in SSG mode, those js script are placed inside the head tag using a link tag like this:
Therefore, I created this PR to remove those link tags containing JS scripts as mentioned above, to ensure that the 'init' mode functions correctly in Nuxt SSG mode.
I have limited experience contributing to open-source projects and I hope to receive feedback and suggestions from everyone. I also hope that my PR will be merged to help others.
Linked Issues
Additional context