Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to esbuild-loader version 2.10 #25

Merged
merged 2 commits into from
Mar 17, 2021
Merged

update to esbuild-loader version 2.10 #25

merged 2 commits into from
Mar 17, 2021

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Mar 16, 2021

With te new Version you don't need the ESBuildPlugin anymore. We can savely remove it.

If this is not merged esbuild-loader version 2.11 (not released jet) will break.

@mathe42 mathe42 changed the title WIP update to new esbuild-loader version WIP update to esbuild-loader version 2.10 Mar 16, 2021
@harlan-zw
Copy link
Owner

Oh cool :) Good idea

@mathe42 mathe42 changed the title WIP update to esbuild-loader version 2.10 update to esbuild-loader version 2.10 Mar 17, 2021
@mathe42
Copy link
Contributor Author

mathe42 commented Mar 17, 2021

@loonpwn Ready for review.

@harlan-zw
Copy link
Owner

lgtm, thank you

@harlan-zw harlan-zw merged commit 268b7d2 into harlan-zw:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants