Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retryable errors don't get retried in master #152

Closed
jtackaberry opened this issue Mar 17, 2023 · 1 comment
Closed

Retryable errors don't get retried in master #152

jtackaberry opened this issue Mar 17, 2023 · 1 comment

Comments

@jtackaberry
Copy link
Contributor

isRetriableError() is broken in master which causes retryable errors to abort. Basically this function needs to look something like:

func isRetriableError(err error) bool {
	var apiErr smithy.APIError
	if !errors.As(err, &apiErr) {
		return false
	}
	switch apiErr.(type) {
	case *types.ExpiredIteratorException:
		return true
	case *types.ProvisionedThroughputExceededException:
		return true
	default:
		return false
	}
}

I can submit a PR but it's not entirely clear whether this project is dead or not, so I'll wait for signs of life before investing the effort. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants