Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP30 - min 7% fee not working for validator with max fee below 7% #4549

Closed
sophoah opened this issue Nov 2, 2023 · 3 comments
Closed

HIP30 - min 7% fee not working for validator with max fee below 7% #4549

sophoah opened this issue Nov 2, 2023 · 3 comments

Comments

@sophoah
Copy link
Contributor

sophoah commented Nov 2, 2023

There are validators with max fees at 5% and the HIP30 protocol automatic increase didn't work:

hmy --node="https://api.s0.t.hmny.io" blockchain validator information one1xrtkrcpx7edw40zxpp26up939gc68u8hwepvnx | jq '.result.validator["max-rate"]'
"0.050000000000000000"

hmy --node="https://api.s0.t.hmny.io" blockchain validator information one132ggm0mgxdt4l8etud9e5gzpv8psgx30p7hxsq | jq '.result.validator["max-rate"]'
"0.050000000000000000"
@sophoah
Copy link
Contributor Author

sophoah commented Nov 13, 2023

@diego1q2w when you have some time could you help check whether your fix will also fix the validator information.

The below output is for a validator currently hitting the 5% fee bug:

hmy --node="https://api.s0.t.hmny.io" blockchain validator information one1rxdtt9fvgdcy3n5sy6e4zxg0s4hn4shaqf4qtp
{
  "id": "0",
  "jsonrpc": "2.0",
  "result": {
    "active-status": "active",
    "booted-status": "lost epos auction",
    "current-epoch-performance": null,
    "currently-in-committee": false,
    "epos-status": "eligible to be elected next epoch",
    "epos-winning-stake": null,

the issue here is that currently this validator is active and signing and some of the field above are not right, see here for another validator also active but not hitting the 5% fee bug

hmy --node="https://api.s0.t.hmny.io" blockchain validator information one1upv5r5y3n5zce7a3wdj4z7pqzussqtdm35rcl5 | more
{
  "id": "0",
  "jsonrpc": "2.0",
  "result": {
    "active-status": "active",
    "booted-status": null,
    "current-epoch-performance": {
      "block": 49638807,
      "current-epoch-signing-percent": {
        "current-epoch-signed": 561830,
        "current-epoch-signing-percentage": "1.000000000000000000",
        "current-epoch-to-sign": 561830
      },
      "epoch": 1687
    },
    "currently-in-committee": true,
    "epos-status": "currently elected",
    "epos-winning-stake": "296673299565500747935060671.600000000000000000",

@ONECasey
Copy link
Contributor

Fixed

@ONECasey
Copy link
Contributor

#4588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants