-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle size extremely large due to inclusion of cities database #60
Comments
Opened #62 to address this |
@taylorthurlow It certainly needs an attention @harpreetkhalsagtbit |
Interested for the same reasons. My bundle size is getting too big, I started thinking of dropping the NPM package. |
@dr5hn @taylorthurlow @TAnas0 |
Great to hear, thanks. I just pushed up rewritten and passing tests to #62. |
I have refactored complete package - Tree Shaking |
@harpreetkhalsagtbit Why was this issue closed? It didn't fix tree shaking. Bundles are still 17+mb. I ended up using @taylorthurlow fork which allows tree shaking. |
Same here, bundle size is 17Mb. I wonder if this PR was actually included in the release? |
@taylorthurlow Can you verify that tree shaking now works for you? |
@cmacdonnacha @taylorthurlow @dr5hn Would you all please share the package version you are testing and also share some code that fails. |
@harpreetkhalsagtbit Sure, package version is
|
Sorry my priorities changed and I haven't switched over from my fork yet. |
Hi, any updates on this? My bundle is also over 16 MB, and it seems impossible to tree shake city.json. |
Same issue, mobile is not loading properly due to this JOLY bundle |
Hi, I'm wondering if there are any plans to address the size of the included JSON database. Uncompressed, the countries, states, and cities databases are more than 16 megabytes, which is still more than 2.5 when fetched with a browser, gzip compressed.
This is sort of a deal-breaker for using this application in production for just countries and states, but would be 100% more usable if there were an option to exclude the cities database when one has no intention of using it. I don't know much about tree shaking and module exclusion, nor do I know how/if that would related to a big JSON document.
Maybe @dr5hn has an opinion or suggestions on this topic?
The text was updated successfully, but these errors were encountered: