Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HSL alpha channel bug. #16

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Fix HSL alpha channel bug. #16

merged 1 commit into from
Feb 19, 2015

Conversation

ben-eb
Copy link
Contributor

@ben-eb ben-eb commented Feb 10, 2015

Strange error when parsing a colour such as hsla(0, 0%, 0%, 0) - alpha channel gets converted to 1. Fixed this in both the HSL and HWB conversion functions, such that this test now passes:

assert.deepEqual(string.getHsla('hsla(0,0%,0%,0)'), [0, 0, 0, 0]);

MoOx added a commit that referenced this pull request Feb 19, 2015
@MoOx MoOx merged commit 8407fb2 into Qix-:master Feb 19, 2015
@ben-eb ben-eb deleted the fix-transparency branch February 19, 2015 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants