Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License text missing from chosen-package #2945

Closed
kreynen opened this issue Jan 31, 2018 · 4 comments · Fixed by #2966 or #2970
Closed

License text missing from chosen-package #2945

kreynen opened this issue Jan 31, 2018 · 4 comments · Fixed by #2966 or #2970
Labels

Comments

@kreynen
Copy link

kreynen commented Jan 31, 2018

While you include https://github.com/harvesthq/chosen/blob/master/LICENSE.md, it is missing from https://github.com/harvesthq/chosen-package

In the MIT license itself, it states...

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

You are making it MUCH harder for downstream users of this code to meet the licensing requirements when you don't include the LICENSE.md for Bower and NPM builds.

@stof
Copy link
Collaborator

stof commented Jan 31, 2018

hmm, we should indeed copy the LICENSE file in the packaged archive.

@tjschuck
Copy link
Member

/cc @adunkman

@tjschuck tjschuck added the Bug label Jan 31, 2018
@kreynen
Copy link
Author

kreynen commented Mar 29, 2018

This is coming up again https://www.drupal.org/project/drupalorg_whitelist/issues/2954806

While I know everyone just wants to focus on writing and sharing code, the role the Licensing Working Group in the Drupal project is vet the code being distributed from Drupal.org for licensing issues. We're similar to Drupal's security team, but much less glamorous :)

Because the MIT license allows the copyright holder to also distribute code under other licenses, we can't really just assume that because the original source was licensed as MIT all derivatives are MIT like we can with GPL licensed code.

To properly distribute this under the license, the Drupal project that wants to include it would have to patch the copyright notice back in.

@tjschuck
Copy link
Member

As of version 1.8.5, https://github.com/harvesthq/chosen-package contains the LICENSE.md file.

Thanks for reporting, @kreynen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants