Merge branch 'hash-org:main' into main

compiler/hash-ast-utils/src/lib.rs

@@ -1,8 +1,9 @@
-//! Defines various utilties that can be used on the AST. Mainly, this
+//! Defines various utilities that can be used on the AST. Mainly, this
 //! crate defines AST printing functionalities, including the `tree` view
-//! and the `pretty` prininging view, in addition to the implementation of
+//! and the `pretty` printing view, in addition to the implementation of
 //! the `#dump_ast` directive.
 #![feature(let_chains)]
+#![allow(dead_code)]
 
 pub mod attr;
 pub mod dump;

compiler/hash-attrs/src/ty.rs

@@ -22,7 +22,7 @@ define_index_type! {
     /// map spans to nodes, and vice versa. [AstNodeId]s are unique and
     /// they are always increasing as a new nodes are created.
     pub struct AttrId = u32;
-    MAX_INDEX = i32::max_value() as usize;
+    MAX_INDEX = i32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 }
 

compiler/hash-exhaustiveness/src/storage.rs

@@ -10,15 +10,15 @@ define_index_type! {
     /// Id of a [DeconstructedPat] in the [ExhaustivenessCtx].
     pub struct DeconstructedPatId = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 }
 
 define_index_type! {
     /// Id of a [DeconstructedCtor] in the [ExhaustivenessCtx].
     pub struct DeconstructedCtorId = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 }
 

compiler/hash-ir/src/ir.rs

@@ -848,7 +848,7 @@ index_vec::define_index_type! {
     /// Index for [BasicBlockData] stores within generated [Body]s.
     pub struct BasicBlock = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 
     DEBUG_FORMAT = "bb{}";
@@ -868,7 +868,7 @@ index_vec::define_index_type! {
     /// Index for [LocalDecl] stores within generated [Body]s.
     pub struct Local = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 
     DEBUG_FORMAT = "_{}";

compiler/hash-lower/src/build/into.rs

@@ -145,7 +145,7 @@ impl<'tcx> BodyBuilder<'tcx> {
             }
             Term::Call(ref fn_term @ CallTerm { subject, args, .. }) => {
                 match self.classify_fn_call_term(fn_term) {
-                    FnCallTermKind::Call(_) => {
+                    FnCallTermKind::Call => {
                         // Get the type of the function into or to to get the
                         // fn-type so that we can enter the scope.
                         let ty = self.ctx.get_inferred_ty(subject);

compiler/hash-lower/src/build/ty.rs

@@ -33,7 +33,7 @@ use super::BodyBuilder;
 pub enum FnCallTermKind {
     /// A function call, the term doesn't change and should just be
     /// handled as a function call.
-    Call(CallTerm),
+    Call,
 
     /// A cast intrinsic operation, we perform a cast from the type of the
     /// first term into the desired second [ReprTyId].
@@ -174,13 +174,13 @@ impl<'tcx> BodyBuilder<'tcx> {
                     | TirIntrinsic::Memcmp
                     | TirIntrinsic::Memcpy
                     | TirIntrinsic::Abort
-                    | TirIntrinsic::Panic => FnCallTermKind::Call(*term),
+                    | TirIntrinsic::Panic => FnCallTermKind::Call,
                     TirIntrinsic::Eval | TirIntrinsic::UserError | TirIntrinsic::DebugPrint => {
                         panic!("Found unexpected intrinsic {} which should have been evaluated during TC", intrinsic)
                     }
                 }
             }
-            _ => FnCallTermKind::Call(*term),
+            _ => FnCallTermKind::Call,
         }
     }
 

compiler/hash-repr/src/ty.rs

@@ -775,7 +775,7 @@ index_vec::define_index_type! {
     /// Index for [VariantIdx] stores within generated [Body]s.
     pub struct VariantIdx = u32;
 
-    MAX_INDEX = i32::max_value() as usize;
+    MAX_INDEX = i32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 
     DEBUG_FORMAT = "variant#{}";

compiler/hash-source/src/lib.rs

@@ -32,7 +32,7 @@ define_index_type! {
     /// A [ModuleId] is a [SourceId] which points to a module.
     pub struct ModuleId = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 
     DEBUG_FORMAT = "module:{}";
@@ -42,7 +42,7 @@ define_index_type! {
     /// An [InteractiveId] is a [SourceId] which points to an interactive block.
     pub struct InteractiveId = u32;
 
-    MAX_INDEX = u32::max_value() as usize;
+    MAX_INDEX = u32::MAX as usize;
     DISABLE_MAX_INDEX_CHECK = cfg!(not(debug_assertions));
 
     DEBUG_FORMAT = "interactive:{}";

compiler/hash-vm/src/lib.rs

@@ -1,6 +1,4 @@
 //! Hash Compiler VM crate.
-#![feature(unchecked_math)]
-
 mod heap;
 mod stack;