Proposed github process modification. #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsync-swirlds
requested review from
rbair23,
steven-sheehy,
tinker-michaelj,
Nana-EC and
a-saksena
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jsync-swirlds
force-pushed
the
add-code-attachment-process
branch
from
a3bea7c to
a951ad1
Compare
jsync-swirlds
force-pushed
the
add-code-attachment-process
branch
from
a951ad1 to
e630ffd
Compare
jsync-swirlds
requested review from
dalvizu and
jeromy-cannon
and removed request for
tinker-michaelj
Nana-EC
previously approved these changes
Nov 6, 2024
This proposed modification adds detail for how to handle specification text that is excessively large, and would only obscure the substance of a HIP if included inline. * Remove two obsolete copied files (both are still present in the `hip` folder, and were identical to those versions). * Clean up the README file, wrap long lines for readbility, and fix some typographic issues. * Clean up the hip-0000-template.md file, wrap long lines for readability (and to encourage the same in HIP documents), and fix some typographic issues * Added content to the "Specification" section to describe a recommended method for handling excessively large specification text, along with a small example. * Added a folder and sample file (copied from HIP-904 implementation) to support the example. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
jsync-swirlds
force-pushed
the
add-code-attachment-process
branch
from
e630ffd to
ff1f16f
Compare
Nana-EC
approved these changes
Nov 7, 2024
rbarkerSL
approved these changes
Nov 8, 2024
|
@mgarbs Any chance of getting this reviewed and merged? |
mgarbs
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed modification adds detail for how to handle specification text that is excessively large, and would only obscure the substance of a HIP if included inline.