Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transactions with the status INVALID_ACCOUNT_ID from block-specific routes #3171

Closed
natanasow opened this issue Oct 29, 2024 · 0 comments · Fixed by #3177
Closed

Remove transactions with the status INVALID_ACCOUNT_ID from block-specific routes #3171

natanasow opened this issue Oct 29, 2024 · 0 comments · Fixed by #3177
Assignees
Labels
bug Something isn't working
Milestone

Comments

@natanasow
Copy link
Collaborator

natanasow commented Oct 29, 2024

Description

Currently, there are transactions that hadn't entered the evm (reverted due to hedera-specific validations) but are included in a generated record file, also they are imported in the mirror node db. These transactions must be excluded from the response to block-related routes.

Steps to reproduce

We should hook in here https://github.com/hashgraph/hedera-json-rpc-relay/pull/3158/files#diff-dd8c7990f7764960d05dcb4c1b5ae7eee48b425b1b83d6dcc7e7ccc442330ef0R2303 and add a type for INVALID_ACCOUNT_ID as well.

These checks must be defined as an environment variable (as an array) and we could be able easily to add/remove transaction statuses.

Additional context

No response

Hedera network

No response

Version

latest

Operating system

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
1 participant