Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_getStorageAt acceptance test coverage #449

Closed
Nana-EC opened this issue Aug 17, 2022 · 2 comments · Fixed by #664
Closed

Add eth_getStorageAt acceptance test coverage #449

Nana-EC opened this issue Aug 17, 2022 · 2 comments · Fixed by #664
Assignees
@lukelee-sl
Labels
enhancement New feature or request P2
Milestone
0.12.0

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Aug 17, 2022

Problem

The relay added support to eth_getStorageAt to call the mirror node.
However, no E2E tests could be added at the time

Solution

Add eth_getStorageAt acceptance test coverage

  • ensure the services node is updated to support side car propogation of state changes

Alternatives

No response
@Nana-EC Nana-EC added the enhancement New feature or request label Aug 17, 2022
@Nana-EC Nana-EC added this to the 0.7.0 milestone Aug 17, 2022
@Nana-EC Nana-EC removed this from the 0.7.0 milestone Aug 19, 2022
@Nana-EC
Copy link
Collaborator Author

Nana-EC commented Aug 19, 2022

state_changes not yet flowing from mirror node. Will have to wait

@Nana-EC Nana-EC added this to the 0.9.0 milestone Sep 16, 2022
@Nana-EC
Copy link
Collaborator Author

Nana-EC commented Sep 16, 2022

State changes will be flowing in 0.30 services and Mirror Node 0.65.0.

Notably the eth_getStorageAt calls can currently only supports the case where the slot in question was modified in the latest transaction for the given contract.
In other scenarios no state change will be found until Mirror Node adds a contract_state table.
This ticket should add tests for the first case and we can add more when the full implementation is added.

@lukelee-sl lukelee-sl mentioned this issue Sep 22, 2022
Closed
2 tasks
@Nana-EC Nana-EC modified the milestones: 0.9.0, 0.10 Oct 6, 2022
@Nana-EC Nana-EC modified the milestones: 0.10, 0.11.0 Oct 17, 2022
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Oct 17, 2022
@lukelee-sl lukelee-sl mentioned this issue Nov 1, 2022
Merged
2 tasks
@Nana-EC Nana-EC modified the milestones: 0.11.0, 0.12.0 Nov 2, 2022
Repository owner moved this from Sprint BackLog to Done in Smart Contract Sprint Board Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukelee-sl lukelee-sl

Labels
enhancement New feature or request P2
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.12.0
2 participants
@Nana-EC @lukelee-sl