Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reason is not sent back in transaction receipt #661

Closed
mshakeg opened this issue Oct 29, 2022 · 0 comments · Fixed by #668
Closed

Revert reason is not sent back in transaction receipt #661

mshakeg opened this issue Oct 29, 2022 · 0 comments · Fixed by #668
Assignees
Labels
bug Something isn't working limechain
Milestone

Comments

@mshakeg
Copy link
Contributor

mshakeg commented Oct 29, 2022

Description

It appears #492 was not entirely resolved in #604 as demonstrated in the error-contract.test.ts script in #660

hedera-local@2.1.3 points to relay 0.10.0 which has #604

Steps to reproduce

(I) On the ErrorContract with stateful function calls(eth_sendRawTransaction/eth_sendTransaction)

  1. In hardhat-example project root run npm run test:hec and observe all 4 tests fail.
  2. In hardhat.config.ts temporarily remove the h_local network to default to the hardhat local node and rerun the above test and observe all 4 tests pass.

(II) #604 seems to only address the issue on eth_call; Demonstrate on the ErrorContract with view/pure function calls(eth_call)

  1. Add pure modifiers to all 4 of ErrorContract's functions
  2. In hardhat-example project root run npm run test:hec and observe only 3/4 tests pass(i.e. the should simply revert test fails)
  3. In hardhat.config.ts temporarily remove the h_local network to default to the hardhat local node and rerun the above test and observe that only 3/4 tests pass(i.e. the should simply revert test fails) just like (II 2.) i.e. when run against the hedera relay.

Additional context

No response

Hedera network

other

Version

@hashgraph/hedera-local@2.1.3

Operating system

macOS

@mshakeg mshakeg added the bug Something isn't working label Oct 29, 2022
@Ivo-Yankov Ivo-Yankov self-assigned this Oct 31, 2022
@Nana-EC Nana-EC added this to the 0.12.0 milestone Nov 1, 2022
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Nov 2, 2022
@Ivo-Yankov Ivo-Yankov linked a pull request Nov 4, 2022 that will close this issue
2 tasks
Repository owner moved this from Sprint BackLog to Done in Smart Contract Sprint Board Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants