Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getLogs does not support filtering by an array of addresses #675

Closed
dimitrovmaksim opened this issue Nov 7, 2022 · 0 comments · Fixed by #719
Closed

eth_getLogs does not support filtering by an array of addresses #675

dimitrovmaksim opened this issue Nov 7, 2022 · 0 comments · Fixed by #719
Assignees
Labels
bug Something isn't working

Comments

@dimitrovmaksim
Copy link
Collaborator

dimitrovmaksim commented Nov 7, 2022

Description

Currently the relay can't handle an array of addresses for the eth_getLogs address filter, which can be either a single address or an array of addresses. The Issue is that the mirror-node doesn't have an endpoint where logs can be filtered by multiple addresses.

One of the solutions is to iterate through all addresses and to do a mirror node request for each address, but in combination with #673 this could result in the getLogs getting extremely inefficient and slow, especially in combination with filtering by block range (fromBlock -> toBlock)

Another solution is to allow the mirror node to be queried by multiple addresses.

Steps to reproduce

Execute eth_getLogs request to the relay with address fields being an array of addresses. The relay will send the request to the mirror node in the following format
[GET] contracts/0x0000000000000000000000000000000002e6f4f3,0x0000000000000000000000000000000002e798e8/results/logs 400 status

Additional context

No response

Hedera network

mainnet, testnet, previewnet, other

Version

all

Operating system

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants