Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show NFT Collections #525

Closed
mshakeg opened this issue Apr 3, 2023 · 3 comments · Fixed by #721
Closed

Show NFT Collections #525

mshakeg opened this issue Apr 3, 2023 · 3 comments · Fixed by #721
Assignees
Labels
enhancement New feature or request P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule tokens Feature related to HTS tokens UI/UX UI/UX design is required

Comments

@mshakeg
Copy link

mshakeg commented Apr 3, 2023

Problem

As a user I would like to view an account's associated HTS NFT collections.
As a user I would like to click on a specific account's NFT collection and view all NFTs owned by serial_id.

Solution

  1. get an account's tokens from the mirror node using /api/v1/accounts/{accountId}/tokens
  2. filter the above tokens for only NFTs
  3. get all serial_ids owned using /api/v1/tokens/{nftId}/nfts for each NFT

Alternatives

No response

@mshakeg mshakeg added the enhancement New feature or request label Apr 3, 2023
@svienot
Copy link
Collaborator

svienot commented Apr 3, 2023

I am not sure how what you describes differs from what is already in place.

On the account view, we list all balances (hbar, fungible tokens and NFTs).
For instance in the balances of this account:
Balances
HSNFT is a class of NFT and the balance indicates the account holds 7 instances of that.
When you click on HSNFT and navigate to the token view, there is the list of all NFT owned by serial numbers.

Are you suggesting we list separately fungible and NFT on the account view?
(note that most of the time there is a link to view all token balances on a separate page since there are too many).

What we had in mind was to enumerate the serial numbers after the NFT label on the account view.
For instance here we might display:
7 HSNFT (#1, #3, #4, #5, #6, #7, #8)
and when there is more than a given number of serial numbers we might instead provide a link to view the serial numbers owned on a separate page:
7 HSNFT (view serial numbers)

@mshakeg
Copy link
Author

mshakeg commented Apr 3, 2023

@svienot correct, part of what I'm suggesting is that the fungible tokens and NFTs be separately listed on the account view.

However, the core issue is that clicking on the NFT on the Account view's balances section redirects to the token view page i.e. /token/{tokenId} which lists all NFT Holders and the serial_id that each account owns. However, IMO it would make more sense to navigate to a page which lists all serial_ids owned by that specific account.

@SimiHunjan SimiHunjan modified the milestone: June 2023 Jun 13, 2023
@SimiHunjan SimiHunjan added P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule UI/UX UI/UX design is required tokens Feature related to HTS tokens labels Jul 25, 2023
@Sheng-Long Sheng-Long self-assigned this Oct 4, 2023
@Sheng-Long
Copy link
Contributor

Sheng-Long commented Oct 4, 2023

Related to #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule tokens Feature related to HTS tokens UI/UX UI/UX design is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants