New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add freeze account #436

Merged

jeromy-cannon merged 2 commits into main from 00308-D-switch-freeze-acount

Jul 30, 2024

Contributor

JeffreyDallas commented Jul 18, 2024 •

edited

Loading

Description

This is a replacement PR for #365

This pull request changes the following:

Using dedicated freeze account to send freeze transaction
Using a shorter system account set in E2E test since signing transactions run very slowly with JEST and would have some list exception after running for a while (probably resource leaks in JEST)

Related Issues

Closes #308


          add freeze account

20e1a4a

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested review from leninmehedy and a team as code owners

July 18, 2024 18:32

JeffreyDallas self-assigned this

JeffreyDallas added the New Feature label

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

Unit Test Results - Linux

1 files 19 suites 1m 22s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
150 runs 150 ✅ 0 💤 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

Unit Test Results - Windows

1 files 19 suites 1m 29s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
150 runs 150 ✅ 0 💤 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Node PEM Stop Add Tests Coverage Report

1 files 1 suites 9m 19s ⏱️
18 tests 18 ✅ 0 💤 0 ❌
20 runs 20 ✅ 0 💤 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Tests Coverage Report

55 tests 55 ✅ 3m 43s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 2m 36s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Node PFX Kill Add Tests Coverage Report

1 files 1 suites 10m 31s ⏱️
18 tests 18 ✅ 0 💤 0 ❌
20 runs 20 ✅ 0 💤 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Mirror Node Tests Coverage Report

11 tests 11 ✅ 3m 27s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 18, 2024 •

edited

Loading

E2E Relay Tests Coverage Report

1 files 1 suites 2m 21s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit a5f938c.

♻️ This comment has been updated with latest results.


          uses a shorter system account set

a5f938c

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested a review from jeromy-cannon

July 18, 2024 19:13

codacy-production bot commented Jul 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `55c6b88`¹	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`55c6b88`)	Report Missing	Report Missing	Report Missing
Head commit (`a5f938c`)	3500	2842	81.20%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#436)	12	12	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov bot commented Jul 18, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (67f47c1) to head (a5f938c).
Report is 49 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   81.44%   81.89%   +0.45%     
==========================================
  Files          35       35              
  Lines        4095     4181      +86     
  Branches      719      725       +6     
==========================================
+ Hits         3335     3424      +89     
+ Misses        760      757       -3

Files	Coverage Δ
src/commands/node.mjs	`77.60% <100.00%> (-0.23%)`	⬇️
src/core/constants.mjs	`94.04% <100.00%> (+0.14%)`	⬆️
test/e2e/e2e_node_util.js	`89.02% <100.00%> (+0.41%)`	⬆️

... and 4 files with indirect coverage changes

jeromy-cannon approved these changes

View reviewed changes

jeromy-cannon merged commit 8fe5a41 into main

37 checks passed

jeromy-cannon deleted the 00308-D-switch-freeze-acount branch

July 30, 2024 13:00

swirlds-automation added a commit that referenced this pull request


          chore(release): 0.28.0 [skip ci]

d5acbe3

## [0.28.0](v0.27.0...v0.28.0) (2024-08-26)

### Features

* add freeze account ([#436](#436)) ([8fe5a41](8fe5a41))
* enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599))
* use k8s configMaps to mount files during solo network deploy  ([#345](#345)) ([af27f16](af27f16))

### Bug Fixes

* hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413))
* reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade))
* Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881))
* use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))

Contributor

swirlds-automation commented Aug 26, 2024

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature released