Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom IP address logic for Mirror Node address book and use DAB #493

Closed
Tracked by #47
jeromy-cannon opened this issue Aug 16, 2024 · 1 comment · Fixed by hashgraph/full-stack-testing#960 or #518
Closed
Tracked by #47

Remove custom IP address logic for Mirror Node address book and use DAB #493

jeromy-cannon opened this issue Aug 16, 2024 · 1 comment · Fixed by hashgraph/full-stack-testing#960 or #518
Assignees
@instamenta
Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Aug 16, 2024 •
edited
Loading

with:

Mirror Node v0.111.0 was released with support for HIP-869 Dynamic Address Book
We should be able to remove dependency for @hashgraph/proto and simply return the results of
await fileQuery.execute(this._nodeClient) at

solo/src/core/account_manager.mjs

Line 629 in 02526f5

let addressBookBytes = await fileQuery.execute(this._nodeClient)

removing all of the custom logic that follows in that function.

requires FST charts to be upgraded to mirror node v0.111.0+ : https://github.com/hashgraph/full-stack-testing/blob/31535b1d09dab8c3cba35712dada4ce647be5959/charts/fullstack-deployment/Chart.yaml#L41
@jeromy-cannon jeromy-cannon mentioned this issue Aug 16, 2024
Open
@jeromy-cannon jeromy-cannon added the Improvement Code changes driven by non business requirements label Aug 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Aug 16, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Aug 16, 2024
@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label Aug 16, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Aug 21, 2024
Closed
@jeromy-cannon jeromy-cannon added the Tech Debt Changes that are needed to keep up with tech debt label Aug 22, 2024
This was linked to pull requests Aug 28, 2024
fix: bump mirror node in FST helm chart to 0.111.1 hashgraph/full-stack-testing#960
Merged
fix: removed the custom ip address logic and '@hashgraph/proto' #518
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Aug 28, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Aug 28, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@instamenta instamenta

Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt
Projects
Solo
Status: ✅ Done
Milestone
No milestone
3 participants
@jeromy-cannon @swirlds-automation @instamenta