Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run JSDoc as a CICD build step without deploying so that we know things break before pushing to main #544

Closed
Tracked by #339
jeromy-cannon opened this issue Sep 4, 2024 · 1 comment · Fixed by #557
Closed
Tracked by #339

Run JSDoc as a CICD build step without deploying so that we know things break before pushing to main #544

jeromy-cannon opened this issue Sep 4, 2024 · 1 comment · Fixed by #557
Assignees
@JeffreyDallas
Labels
P3 Low priority issue. Will not impact the release schedule if not complete. released Testing Improvements Improvements that will result in better test coverage or more efficient testing

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Sep 4, 2024 •
edited
Loading

Currently the job Deploy Hugo site to Pages runs an install of JSDoc which fails upon occasion after the code has merged to main. it would be good to have the job run without error but not deploy anything as part of a PR Check.

relates to: #543
@jeromy-cannon jeromy-cannon added P3 Low priority issue. Will not impact the release schedule if not complete. Testing Improvements Improvements that will result in better test coverage or more efficient testing labels Sep 4, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Sep 4, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Sep 4, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 10, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Sep 12, 2024
Open
@JeffreyDallas JeffreyDallas mentioned this issue Sep 10, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
P3 Low priority issue. Will not impact the release schedule if not complete. released Testing Improvements Improvements that will result in better test coverage or more efficient testing
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jsdoc errors due to unrecognized format hashgraph/solo
3 participants
@jeromy-cannon @JeffreyDallas @swirlds-automation