Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Add Support for Tolerations #426

Merged
merged 14 commits into from
Nov 3, 2022
Merged

Add Support for Tolerations #426

merged 14 commits into from
Nov 3, 2022

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented Oct 24, 2022 •
edited by nathancoleman
Loading

Changes proposed in this PR:

  • Add support for configurable tolerations
  • Relies on a change made in consul-k8s here

How I've tested this PR:

  • Updated tests to include
  • Add test (wip)

How I expect reviewers to test this PR:

  • Tests past in CI

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@sarahalsmiller sarahalsmiller mentioned this pull request Oct 25, 2022
Merged
1 task
@sarahalsmiller sarahalsmiller added the pr/conformance Run conformance tests from kubernetes-sigs/gateway-api label Oct 25, 2022
@sarahalsmiller sarahalsmiller marked this pull request as ready for review October 26, 2022 20:53
sarahalsmiller and others added 4 commits November 1, 2022 10:08
@sarahalsmiller @nathancoleman
Update config/crd/bases/api-gateway.consul.hashicorp.com_gatewayclass…
02415da 
…configs.yaml

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
@sarahalsmiller @nathancoleman
Update pkg/apis/v1alpha1/types.go
4885921 
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
@sarahalsmiller
regen files
b587825
@sarahalsmiller
Update conformance.yml
42585e2
@sarahalsmiller sarahalsmiller removed the pr/conformance Run conformance tests from kubernetes-sigs/gateway-api label Nov 1, 2022
Merged
1 task
@sarahalsmiller sarahalsmiller merged commit 7dadeca into main Nov 3, 2022
@sarahalsmiller sarahalsmiller deleted the sa-consul-api-gateway-toleration-support branch November 3, 2022 19:45
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nathancoleman nathancoleman nathancoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahalsmiller @nathancoleman