Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/hashicorp/consul/ dependency #113

Open
2 of 6 tasks
eikenb opened this issue Aug 17, 2021 · 1 comment
Open
2 of 6 tasks

Remove github.com/hashicorp/consul/ dependency #113

eikenb opened this issue Aug 17, 2021 · 1 comment

Comments

@eikenb
Copy link
Contributor

eikenb commented Aug 17, 2021

Only github.com/hashicorp/consul/api and github.com/hashicorp/consul/sdk are designed to be externally imported. All other imports of consul need to be removed. This includes...

  • github.com/hashicorp/consul/logger
  • github.com/hashicorp/consul/command/flags
  • github.com/hashicorp/consul/agent/checks
  • github.com/hashicorp/consul/agent/structs
  • github.com/hashicorp/consul/lib
  • github.com/hashicorp/consul/types

Either need to replace what it is importing or cut-n-paste into a local file.

@eikenb
Copy link
Contributor Author

eikenb commented Aug 18, 2021

At this point only these 2 were low hanging fruit and were easy to remove.

github.com/hashicorp/consul/command/flags
github.com/hashicorp/consul/agent/structs

All the rest will require significant amounts of work that should wait until I better understand the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant