-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v2 mesh-init command #2941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!! Nicely done!!
4b19620
to
3fff705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some minor comments but overall the adaptation of the existing command makes sense to me.
control-plane/connect-inject/constants/annotations_and_labels.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
I see the WANfed acceptance test failing in another commit on |
Changes proposed in this PR:
mesh-init
that replacesconnect-init
for V2 workloads. This uses the dataplane RPC to get the bootstrap config necessary for IPtables configuration. It also allows the workload time to reconcile in Consul before starting the rest of the pod.partition-init
, since the V1 API will still work for this.ACL Support is planned in the next release.
There is a follow-up task I will make to update all the
connect-inject=truthy
annotations in helm to also includemesh-inject
.How I've tested this PR: Unit/Integration tests with the Consul test server.
How I expect reviewers to test this PR: 👁️ 🔍
connect-init
command.Checklist:
CHANGELOG entry added